[llvm-commits] [llvm] r77706 - in /llvm/trunk: include/llvm/Support/Annotation.h lib/Support/Annotation.cpp

[Nicolas Geoffray]

Hi Dan,

Dan Gohman wrote:
> Author: djg
> Date: Fri Jul 31 13:36:25 2009
> New Revision: 77706
>
> URL: http://llvm.org/viewvc/llvm-project?rev=77706&view=rev
> Log:
> Remove Annotation.h, which is no longer used in the LLVM tree.
>   

I know this has been long waiting for LLVM and I'm happy you got rid of 
it. Unfortunately, I was using Annotations to add VM-info per function 
in VMKit (e.g. a way to get the Java method out of a llvm::Function), 
and I'm reluctant into using a table to store that information now that 
the Annotation class is removed.

Another way for me is to derive the llvm::Function class, add the 
information in the new class and always create this new class instead of 
llvm::Function. Do you know if that won't mess with the llvm passes?

To implement this solution, one obvious change I need to do in the llvm 
source tree is to set the llvm::Function constructor protected instead 
of private.

Let me know what you think.

Thanks,
Nicolas