[llvm-commits] [llvm] r77904 - in /llvm/trunk: include/llvm/CodeGen/RegisterScavenging.h lib/CodeGen/RegisterScavenging.cpp test/CodeGen/Blackfin/load-intr.ll

[Evan Cheng]

On Aug 2, 2009, at 11:28 AM, Jakob Stoklund Olesen wrote:

>
> /// setUsed - Set the register and its sub-registers as being used.
> void RegScavenger::setUsed(unsigned Reg) {
>   RegsAvailable.reset(Reg);
> @@ -218,7 +226,7 @@
>     const MachineOperand MO = *UseMOs[i].first;
>     unsigned Reg = MO.getReg();
>
> -    assert(isUsed(Reg) && "Using an undefined register!");
> +    assert((MO.isImplicit() || isUsed(Reg)) && "Using an undefined  
> register!");

Hi Jakob,

I don't understand why this is necessary. It's seems like it will end  
up letting a lot of real errors go through.

Evan

>
>     if (MO.isKill() && !isReserved(Reg)) {
>       KillRegs.set(Reg);
> @@ -269,7 +277,8 @@
>
>     // Implicit def is allowed to "re-define" any register. Similarly,
>     // implicitly defined registers can be clobbered.
> -    assert((isReserved(Reg) || isUnused(Reg) ||
> +    assert((MO.isImplicit() || isReserved(Reg) || isUnused(Reg) ||
> +            isSuperRegUsed(Reg) ||
>             isLiveInButUnusedBefore(Reg, MI, MBB, TRI, MRI)) &&
>            "Re-defining a live register!");
>     setUsed(Reg);
>
> Modified: llvm/trunk/test/CodeGen/Blackfin/load-intr.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Blackfin/load-intr.ll?rev=77904&r1=77903&r2=77904&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/test/CodeGen/Blackfin/load-intr.ll (original)
> +++ llvm/trunk/test/CodeGen/Blackfin/load-intr.ll Sun Aug  2  
> 13:28:41 2009
> @@ -1,7 +1,4 @@
> ; RUN: llvm-as < %s | llc -march=bfin -verify-machineinstrs |  
> FileCheck %s
> -; XFAIL: *
> -; Assertion failed: (isUsed(Reg) && "Using an undefined register!"),
> -; function forward, file lib/CodeGen/RegisterScavenging.cpp, line  
> 221.
>
> define i16 @f(i32* %p) nounwind {
> entry:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits