[llvm-commits] [llvm] r77747 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp

[Dan Gohman]

On Jul 31, 2009, at 4:00 PM, Eli Friedman wrote:

> On Fri, Jul 31, 2009 at 3:41 PM, Bob Wilson<bob.wilson at apple.com>  
> wrote:
>> Author: bwilson
>> Date: Fri Jul 31 17:41:21 2009
>> New Revision: 77747
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=77747&view=rev
>> Log:
>> Allow target intrinsics that return multiple values, i.e., struct  
>> types,
>> in SelectionDAGLowering::visitTargetIntrinsic.
>>
>> This removes a bit of special-case code for vector types.  After  
>> staring
>> at it for a while, I managed to convince myself that it is not  
>> necessary.
>> The only case where TLI.getValueType() differs from MVT::getMVT is  
>> for iPTR,
>> so this code could potentially make a difference for a vector of  
>> pointers.
>> But, it looks like that is not supported.
>
> Yes, a vector of pointers isn't legal; we only support integer and  
> FP vectors.

And if that ever changes (:-)) TLI.getValueType(), which is what
ComputeValueVTs uses, would best handle pointer vectors itself,
so this commit is the right thing to do, regardless.

Dan