[llvm-commits] [llvm] r77499 - /llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

[Chris Lattner]

On Jul 31, 2009, at 12:58 PM, David Greene wrote:

> On Friday 31 July 2009 14:52, Chris Lattner wrote:
>
>>> This is kind of an ugly way to output a mix of data and
>>> instructions.  I
>>> wonder if we can invent a better way to support this in the future.
>>
>> This specific one must be emitted that way exactly because of the way
>> TLS relocations work on ELF.  Yes, it's a gross hack, but I don't
>> think there is a much better way to do it.  The actual formatting of
>> the instructions emitted doesn't matter of course, they could be
>> emitted onto multiple lines etc if desired.
>
> It's actually the formatting I was talking about.  I understand the  
> TLS
> relocation issue.  Right now I don't think it's easy to make  
> AsmWriterEmitter
> output this as multiple lines without hard-coding \n into the  
> string, and that
> won't get picked up by the column padding code as a new line since  
> we're
> only looking at tabs and operand count.
>
> Not a big deal right now, just something I noted.

Ah makes sense. If all the other instructions are pretty and this one  
is ugly, I will consider that a big success.  We can always worry  
about this instruction later :)

-Chris