[llvm-commits] [llvm] r77422 - in /llvm/trunk: lib/Target/ARM/ARMConstantIslandPass.cpp lib/Target/ARM/ARMISelLowering.cpp lib/Target/ARM/ARMISelLowering.h lib/Target/ARM/ARMInstrInfo.td lib/Target/ARM/ARMInstrThumb2.td lib/Target/ARM/AsmPrinter/

[Evan Cheng]

Nevermind. I've fixed it.

Evan
On Jul 31, 2009, at 11:24 AM, Evan Cheng wrote:

> Can you send me a test case?
>
> Thanks,
>
> Evan
>
> On Jul 31, 2009, at 11:02 AM, Sandeep Patel wrote:
>
>> On Fri, Jul 31, 2009 at 5:38 PM, Evan Cheng<evan.cheng at apple.com>
>> wrote:
>>>
>>> On Jul 31, 2009, at 9:42 AM, Sandeep Patel wrote:
>>>
>>>> This can generate tbb tables that end up misaligning the code to a
>>>> byte boundary.
>>>
>>> Is this a real problem? tbb tables are byte entries. Do you mean  
>>> tbh?
>>> The ARM documentation does not mention any alignment requirement.
>>>
>>> If this is necessary, we'll have to teach the constant island pass  
>>> as
>>> well.
>>
>> Yes, it's real; I debugged a crash and applied this patch to fix it.
>>
>> Thumb instructions need to be 2-byte aligned. Section A3.2 of the ARM
>> v7-A architecture doc lists this requirement.
>>
>> I haven't looked at the constant island pass. Please apply a fix if
>> you can.
>>
>> deep
>>
>>> Evan
>>>
>>>>
>>>> A patch is attached.
>>>>
>>>> deep
>>>> <tbb_align.diff>_______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits