[llvm-commits] VM hooks when locking

[Nicolas Geoffray]

Owen Anderson wrote:
>
> On Jul 31, 2009, at 12:24 AM, Nicolas Geoffray wrote:
>> Another solution would be to only call the hooks with the JIT lock. The
>> other locks are all internals and won't block the threads too long.
>> Would you prefer that solution? That requires to track all places where
>> the JIT lock is used, so it's more error-prone.
>
> I like this solution better in general, 

Great! I'll submit a new patch then.

> and I don't think it needs to be error-prone.  Why not introduce a 
> little wrapper class for the JIT lock which calls the hooks before and 
> after locking the real lock?

Yeah, I would have coded a wrapper to factorize the calls to the hooks 
anyway. The problem is that the wrapper must always be used, and 
everyone hacking on llvm's execution engine should keep that in mind 
when locking the JIT lock.

Thanks,
Nicolas

>
> --Owen
> ------------------------------------------------------------------------
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>