[llvm-commits] [llvm] r77149 - /llvm/trunk/lib/VMCore/Value.cpp

Dan Gohman gohman at apple.com
Mon Jul 27 14:07:16 PDT 2009


On Jul 26, 2009, at 2:22 AM, Daniel Dunbar wrote:


> Author: ddunbar
> Date: Sun Jul 26 04:22:02 2009
> New Revision: 77149
>
> URL: http://llvm.org/viewvc/llvm-project?rev=77149&view=rev
> Log:
> Make sure getName().data() is always null terminated.

Hi Daniel,

The doxygen comment for StringRef::data() says it may not be null
terminated. This is also consistent with std::string. If there are
clients that need a nul-terminated string, shouldn't there be a
c_str() method?

Dan




More information about the llvm-commits mailing list