[llvm-commits] [llvm] r77225 - /llvm/trunk/include/llvm/Support/MemoryObject.h

[Bill Wendling]

On Mon, Jul 27, 2009 at 11:33 AM, Sean Callanan<scallanan at apple.com> wrote:
> Author: spyffe
> Date: Mon Jul 27 13:33:24 2009
> New Revision: 77225
>
> URL: http://llvm.org/viewvc/llvm-project?rev=77225&view=rev
> Log:
> Many of Daniel's fixes.
>
> I'm returning the number of bytes actually copied so that the client has some
> warning when it reads past the end of the buffer.
>
> I'm keeping the distinction between getByte() and getBytes() for now for
> subclasses that use functions like ptrace() on Linux and only have a restricted
> interface.  This makes their implementation easier, and subclasses can always
> write a one-line implementation of readByte() that uses their custom
> readBytes().
>
> Modified:
>    llvm/trunk/include/llvm/Support/MemoryObject.h
>
> Modified: llvm/trunk/include/llvm/Support/MemoryObject.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/MemoryObject.h?rev=77225&r1=77224&r2=77225&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/MemoryObject.h (original)
> +++ llvm/trunk/include/llvm/Support/MemoryObject.h Mon Jul 27 13:33:24 2009
> @@ -19,21 +19,21 @@
>  ///   file, or on a remote machine.
>  class MemoryObject {
>  public:
> -  /// Constructor     - Override as necessary.
> -  MemoryObject() {
> +  /// Destructor      - Override as necessary.
> +  ~MemoryObject() {
>   }
>
If it's meant to be overridden, it should be marked "virtual".

-bw