[llvm-commits] [llvm] r76999 - in /llvm/trunk: include/llvm/Target/TargetAsmInfo.h lib/Target/TargetAsmInfo.cpp

[Chris Lattner]

Author: lattner
Date: Fri Jul 24 15:27:11 2009
New Revision: 76999

URL: http://llvm.org/viewvc/llvm-project?rev=76999&view=rev
Log:
fix some predicates

Modified:
    llvm/trunk/include/llvm/Target/TargetAsmInfo.h
    llvm/trunk/lib/Target/TargetAsmInfo.cpp

Modified: llvm/trunk/include/llvm/Target/TargetAsmInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetAsmInfo.h?rev=76999&r1=76998&r2=76999&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Target/TargetAsmInfo.h (original)
+++ llvm/trunk/include/llvm/Target/TargetAsmInfo.h Fri Jul 24 15:27:11 2009
@@ -57,13 +57,11 @@
 
     static inline bool isReadOnly(Kind K) {
       return (K == SectionKind::ROData ||
+              K == SectionKind::DataRelRO ||
+              K == SectionKind::DataRelROLocal ||
               K == SectionKind::RODataMergeConst ||
               K == SectionKind::RODataMergeStr);
     }
-
-    static inline bool isBSS(Kind K) {
-      return K == SectionKind::BSS;
-    }
   }
 
   namespace SectionFlags {
@@ -601,7 +599,8 @@
     
     /// getSpecialCasedSectionGlobals - Allow the target to completely override
     /// section assignment of a global.
-    /// FIXME: ELIMINATE
+    /// FIXME: ELIMINATE this by making PIC16 implement ADDRESS with
+    /// getFlagsForNamedSection.
     virtual const Section *
     getSpecialCasedSectionGlobals(const GlobalValue *GV,
                                   SectionKind::Kind Kind) const{

Modified: llvm/trunk/lib/Target/TargetAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetAsmInfo.cpp?rev=76999&r1=76998&r2=76999&view=diff

==============================================================================
--- llvm/trunk/lib/Target/TargetAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/TargetAsmInfo.cpp Fri Jul 24 15:27:11 2009
@@ -341,7 +341,7 @@
   if (Kind == SectionKind::Text)
     return getTextSection();
   
-  if (isBSS(Kind))
+  if (Kind == SectionKind::BSS)
     if (const Section *S = getBSSSection_())
       return S;