[llvm-commits] [llvm] r76982 - in /llvm/trunk: include/llvm/Transforms/IPO/InlinerPass.h lib/Transforms/IPO/Inliner.cpp lib/Transforms/Scalar/DeadStoreElimination.cpp lib/Transforms/Scalar/JumpThreading.cpp lib/Transforms/Scalar/SimplifyHalfPowrL

Dan Gohman gohman at apple.com
Fri Jul 24 11:32:15 PDT 2009



On Jul 24, 2009, at 11:22 AM, Eli Friedman <eli.friedman at gmail.com>  
wrote:

> On Fri, Jul 24, 2009 at 11:13 AM, Dan Gohman<gohman at apple.com> wrote:
>> @@ -117,8 +118,9 @@
>>     // If this is a store-store dependence, then the previous store  
>> is dead so
>>     // long as this store is at least as big as it.
>>     if (StoreInst *DepStore = dyn_cast<StoreInst>(InstDep.getInst()))
>> -      if (TD.getTypeStoreSize(DepStore->getOperand(0)->getType()) <=
>> -          TD.getTypeStoreSize(SI->getOperand(0)->getType())) {
>> +      if (!TD ||
>> +          TD->getTypeStoreSize(DepStore->getOperand(0)->getType())  
>> <=
>> +          TD->getTypeStoreSize(SI->getOperand(0)->getType())) {
>>         // Delete the store and now-dead instructions that feed it.
>>         DeleteDeadInstruction(DepStore);
>>         NumFastStores++;
>
> This change looks suspicious.

Fixed. Thanks for spotting this!

Dan



More information about the llvm-commits mailing list