[llvm-commits] [PATCH] Add support for promoting integer SETCC

Jakob Stoklund Olesen stoklund at 2pi.dk
Fri Jul 24 11:08:42 PDT 2009


On 24/07/2009, at 19.58, Eli Friedman wrote:
>> If SETCC is marked "Custom", won't it be OK to create such a node at
>> this point?
>> Won't the custom LowerOperation() be called after SimplifySetCC() in
>> that case?
>
> By what?  Note that this is *after* operation legalization.

I am confusing custom lowering with custom instruction selection.
You are right.

I will commit with this condition:

if (DCI.isBeforeLegalizeOps() ||
               (isOperationLegal(ISD::SETCC, newVT) &&
                getCondCodeAction(Cond, newVT)==Legal))

Thanks again,
/jakob




More information about the llvm-commits mailing list