[llvm-commits] [PATCH] Add support for promoting integer SETCC
Eli Friedman
eli.friedman at gmail.com
Fri Jul 24 09:43:39 PDT 2009
On Fri, Jul 24, 2009 at 8:10 AM, Jakob Stoklund Olesen<stoklund at 2pi.dk> wrote:
>
> On 24/07/2009, at 09.53, Duncan Sands wrote:
>
>>> OK to commit?
>>
>> How about sending the patch again - I for one seem
>> to have deleted your original email :O
>
> Certainly.
>
> New patch attached, including change suggested by Eli.
You didn't actually change it precisely per my suggestion... you
should be using isOperationLegal instead of isOperationLegalOrCustom.
> Considering the recent discussion about commit policy, is this type of
> bugfix patch "trivial" enough to review-after-commit?
Yes, this type of change is small enough to review-after-commit, if
you're confident the change is correct.
-Eli
More information about the llvm-commits
mailing list