[llvm-commits] [llvm] r76843 - in /llvm/trunk: lib/Target/X86/X86InstrSSE.td test/CodeGen/X86/vec_insertps-1.ll

[Eric Christopher]

On Jul 22, 2009, at 11:07 PM, Evan Cheng wrote:

> In this case, your INSERTPSrr is correct, the previous one, which
> specifies a FR32 as source 2, is wrong.  The register form should take
> a 128-bit vector value. Please keep your INSERTPSrr instruction and
> pattern.
>
> Next step is to fix X86TargetLowering::LowerINSERT_VECTOR_ELT_SSE4 in
> X86ISelLowering.cpp


Yep. Was going to incrementally add things in and make sure I could  
test the stuff we did have. More on that tomorrow, thanks for the  
pointers for where to look!

-eric