[llvm-commits] [llvm-gcc-4.2] r76781 [5/5] - in /llvm-gcc-4.2/trunk: ./ gcc/ gcc/config/ gcc/config/arm/ gcc/config/rs6000/ gcc/cp/ gcc/doc/ gcc/testsuite/g++.apple/ gcc/testsuite/g++.dg/abi/ gcc/testsuite/gcc.apple/ gcc/testsuite/gcc.target/arm/ gcc/testsuite/gcc.target/arm/neon/ gcc/testsuite/obj-c++.dg/ gcc/testsuite/objc.dg/

Bob Wilson bob.wilson at apple.com
Wed Jul 22 22:50:01 PDT 2009


On Jul 22, 2009, at 9:00 PM, Duncan Sands wrote:

> Hi Bob,
>
>> Added: llvm-gcc-4.2/trunk/gcc/testsuite/gcc.target/arm/neon/ 
>> vreinterprets8_s64.c
>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/testsuite/gcc.target/arm/neon/vreinterprets8_s64.c?rev=76781&view=auto
>
> where's the commit message explaining what you're doing?
>
>> --- llvm-gcc-4.2/trunk/gcc/varasm.c (original)
>> +++ llvm-gcc-4.2/trunk/gcc/varasm.c Wed Jul 22 15:36:27 2009
>> @@ -4758,6 +4758,7 @@
>>       && GET_CODE (XEXP (DECL_RTL (decl), 0)) == SYMBOL_REF)
>>     SYMBOL_REF_WEAK (XEXP (DECL_RTL (decl), 0)) = 1;
>> #endif
>> +  /* LLVM LOCAL end */
>
> Not sure why this change is lumped in with a bunch of new testcases.
> I've got to admit that it's harmless though :)
>
>> -#define VERSUFFIX " (Based on Apple Inc. build 5646) (LLVM build "  
>> LLVM_VERSION_INFO ")"
>> +#define VERSUFFIX " (Based on Apple Inc. build 5647) (LLVM build "  
>> LLVM_VERSION_INFO ")"
>> #else
>> -#define VERSUFFIX " (Based on Apple Inc. build 5646) (LLVM build)"
>> +#define VERSUFFIX " (Based on Apple Inc. build 5647) (LLVM build)"
>> #endif
>> #else
>> -#define VERSUFFIX " (Based on Apple Inc. build 5646)"
>> +#define VERSUFFIX " (Based on Apple Inc. build 5647)"
>
> Likewise.

I forgot to mention that Bill did most of the work of this merge from  
Apple's GCC.  He did all the nice work that he usually does with these  
merges.  The changes above were fixing a missing LLVM LOCAL marker and  
updating the version strings to match the version of Apple's GCC that  
was merged in.

He handed it off to me to sort out some problems associated with  
merging the ARM v7 changes, and I committed it when I got it working.   
But please give all the credit to Bill ;-)



More information about the llvm-commits mailing list