[llvm-commits] [llvm] r76666 - /llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.cpp

[Richard Osborne]

Chris Lattner wrote:
>>
>> It would be nice if there was a mechanism to specify target specific
>> sections flags for a section, but I don't think this exists at the
>> moment. As things stand these changes will break things on the XCore
>> since the "c" and "d" flags will no longer be emitted.
>>     
>
> Ok.  Please add some testcases (xfailed if needbe) and I'll work on  
> fixing this.  It sounds like it should fall out nicely from the rest  
> of the cleanup I'm working on.  Is the tree currently in a working  
> state for you, or is it broken?  I see uses of SectionFlags::Small in  
> XCoreTargetAsmInfo::XCoreTargetAsmInfo, I don't know if that is enough  
> to make things work for you.  If not, is it ok for me to remove those?
>
> -Chris
>   
Feel free to remove the uses of SectionFlags::Small since I don't think 
it makes
sense to use this flag anymore. The tree is currently broken for the XCore.
I'll try to put together a set of tests to cover these cases.