[llvm-commits] [llvm] r76733 - in /llvm/trunk: lib/Target/ELFTargetAsmInfo.cpp test/CodeGen/Mips/2008-07-22-Cstpool.ll

[Chris Lattner]

On Jul 22, 2009, at 3:35 AM, Duncan Sands wrote:

> Author: baldrick
> Date: Wed Jul 22 05:35:05 2009
> New Revision: 76733
>
> URL: http://llvm.org/viewvc/llvm-project?rev=76733&view=rev
> Log:
> Revert commit 76707, it was breaking the llvm-gcc build
> on linux platforms.  The binutils assembler does not
> recognize the "s" flag, see for example
> http://sourceware.org/binutils/docs/as/Section.html

Thank you for reverting this for me Duncan, I appreciate you  
unbreaking the tree.

Does anyone know what the deal is with this flag?  Is it supported on  
some targets, but not others?  Is it supported for some kinds of  
globals but not others?  BFD has this comment:

   {* This section contains "short" data, and should be placed
      "near" the GP.  *}
#define SEC_SMALL_DATA 0x400000

Which isn't super helpful.  It's unclear to me exactly what this is  
useful for, since the assembler is being told the size of the elements  
in the section.

The uses I see in the tree are:

- various places where we use the flag if set
- XCore, which is abusing it (I'll respond to Richard separately)
- Mips which clears it in "SectionFlagsForGlobal" because it "doesn't  
support it"

Does anyone have any objections if I just rip it out and come up with  
another solution for Xcore?

-Chris