[llvm-commits] [llvm] r76558 - in /llvm/trunk: lib/CodeGen/VirtRegRewriter.cpp test/CodeGen/X86/2009-07-21-RewriterBug.ll

[David Greene]

On Tuesday 21 July 2009 17:47, Chris Lattner wrote:
> On Jul 21, 2009, at 3:44 PM, Evan Cheng wrote:
> >> Is the testcase worth it then?  Having regression tests is always a
> >> balance between catching future bugs and slowing down all testing.
> >> If
> >> you add a large testcase, it becomes less interesting to have it in
> >> the suite.
> >
> > I've fine with removing the test case.
>
> Ok, please do, thanks.

PLEASE reconsider.  As Evan noted, register allocation bugs are some of the 
most subtle and difficult to track down.  Testcases are a real blessing.  
Better to slow down testing and get it right than ram through and silently 
produce wrong code.

                              -Dave