[llvm-commits] [llvm] r76680 - in /llvm/trunk/lib/CodeGen: LiveInterval.cpp SimpleRegisterCoalescing.cpp

[David Greene]

On Tuesday 21 July 2009 18:59, Bill Wendling wrote:

> > +  else if (Other.weight != HUGE_VALF) {
> > +    weight += Other.weight;
>
> Since this is the only  option available at this time, please make
> this the first "if-then" statement instead of the one above it, which
> asserts all of the time.

Yep, makes sense.

> > +  }
> > +  else {
> > +    // Remove this assert if you have an iterative coalescer
> > +    assert(0 && "Joining from spilled interval");
> > +  }
> > +  // Otherwise the weight stays the same
>
> This comment is confusing. Should it be moved into the "-else" part?

Oops.  I forgot to move it after adding the assert.

                             -Dave