[llvm-commits] [llvm] r76602 - /llvm/trunk/include/llvm/Support/Dump.h

[David Greene]

On Tuesday 21 July 2009 18:51, Bill Wendling wrote:
> On Tue, Jul 21, 2009 at 4:37 PM, David Greene<dag at cray.com> wrote:
> > On Tuesday 21 July 2009 16:37, Bill Wendling wrote:
> >> I'm really not in love with this class at all...
> >
> > Can you explain?
>
> In particular, I don't like it passing back a std::string by value. Is
> it necessary? It's a pretty costly thing to do... If the idea is to
> output stuff to a raw_ostream (say), then why not let the methods do
> that directly?

Ok, I'll try that in the revision.

                             -Dave