[llvm-commits] [llvm] r76615 - in /llvm/trunk: include/llvm/CodeGen/LiveIntervalAnalysis.h lib/CodeGen/LiveIntervalAnalysis.cpp

[David A. Greene]

On Tuesday 21 July 2009 15:09, Chris Lattner wrote:

> This is nice, but:
> > +++ llvm/trunk/include/llvm/CodeGen/LiveIntervalAnalysis.h Tue Jul
> > 21 13:56:32 2009
> > @@ -27,7 +27,9 @@
> > #include "llvm/ADT/SmallPtrSet.h"
> > #include "llvm/ADT/SmallVector.h"
> > #include "llvm/Support/Allocator.h"
> > +#include "llvm/Support/Dump.h"
> > #include <cmath>
> > +#include <sstream>
>
> You're adding more std::*stream stuff to header files.

Will fix.

> > +  // IntervalPrefixPrinter - Print live interval indices before each
> > +  // instruction.
> > +  class IntervalPrefixPrinter : public PrefixPrinter {
>
> David, please talk about general infrastructure like this before just
> applying it to mainline with no review.

I thought the policy was "review after commit."

> Remember that you have *commit after approval* access, with exceptions

Really?

"If you have recently been granted commit access, these policies apply:"

Is two years ago "recent?"

> for "obvious" patches.  This is not obvious and you are not a
> maintainer for these areas.  Please read this for more information:
> http://llvm.org/docs/DeveloperPolicy.html#commitaccess

Even if I am "recent:"

3. You are allowed to commit patches without approval to those portions of 
   LLVM that you have contributed or maintain 

I certainly have contributed to these areas.

It's fine if this is the new policy, but having the goalposts moved gets 
frustrating.

> Please revert r76602+ and propose them to llvm-commits.

I see someone already did.  Would've been nice to get an e-mail about it.

                               -Dave