[llvm-commits] [llvm] r76664 - in /llvm/trunk/lib/Target/XCore: XCoreTargetAsmInfo.cpp XCoreTargetAsmInfo.h

Chris Lattner sabre at nondot.org
Tue Jul 21 15:36:54 PDT 2009


Author: lattner
Date: Tue Jul 21 17:36:53 2009
New Revision: 76664

URL: http://llvm.org/viewvc/llvm-project?rev=76664&view=rev
Log:
remove the Xcore implementation of SelectSectionForGlobal.  While you have
to twist your brain to see it, I believe it is the same as ELFTargetAsmInfo::SelectSectionForGlobal.

Modified:
    llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.cpp
    llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.h

Modified: llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.cpp?rev=76664&r1=76663&r2=76664&view=diff

==============================================================================
--- llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.cpp Tue Jul 21 17:36:53 2009
@@ -68,27 +68,6 @@
   DwarfMacroInfoSection = "\t.section\t.debug_macinfo,\"\", at progbits";
 }
 
-const Section*
-XCoreTargetAsmInfo::SelectSectionForGlobal(const GlobalValue *GV) const {
-  SectionKind::Kind Kind = SectionKindForGlobal(GV);
-
-  if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GV)) {
-    if (!GVar->isWeakForLinker()) {
-      switch (Kind) {
-      case SectionKind::RODataMergeConst:
-        return getReadOnlySection();
-      case SectionKind::ThreadData:
-        return DataSection;
-      case SectionKind::ThreadBSS:
-        return getBSSSection_();
-      default:
-        break;
-      }
-    }
-  }
-  return ELFTargetAsmInfo::SelectSectionForGlobal(GV);
-}
-
 unsigned XCoreTargetAsmInfo::
 SectionFlagsForGlobal(const GlobalValue *GV, const char* Name) const {
   unsigned Flags = ELFTargetAsmInfo::SectionFlagsForGlobal(GV, Name);

Modified: llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.h?rev=76664&r1=76663&r2=76664&view=diff

==============================================================================
--- llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.h (original)
+++ llvm/trunk/lib/Target/XCore/XCoreTargetAsmInfo.h Tue Jul 21 17:36:53 2009
@@ -28,7 +28,6 @@
   public:
     explicit XCoreTargetAsmInfo(const XCoreTargetMachine &TM);
     
-    virtual const Section* SelectSectionForGlobal(const GlobalValue *GV) const;
     virtual unsigned
     SectionFlagsForGlobal(const GlobalValue *GV = NULL,
                           const char* name = NULL) const;





More information about the llvm-commits mailing list