[llvm-commits] [llvm] r76472 - in /llvm/trunk: lib/CodeGen/TwoAddressInstructionPass.cpp test/CodeGen/Thumb/2009-07-20-TwoAddrBug.ll

[Evan Cheng]

Author: evancheng
Date: Mon Jul 20 16:16:08 2009
New Revision: 76472

URL: http://llvm.org/viewvc/llvm-project?rev=76472&view=rev
Log:
Use TII->findCommutedOpIndices to find the commute operands (rather than guessing).

Added:
    llvm/trunk/test/CodeGen/Thumb/2009-07-20-TwoAddrBug.ll
Modified:
    llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp

Modified: llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp?rev=76472&r1=76471&r2=76472&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp (original)
+++ llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp Mon Jul 20 16:16:08 2009
@@ -879,10 +879,14 @@
             // so, swap the B and C operands.  This makes the live ranges of A
             // and C joinable.
             // FIXME: This code also works for A := B op C instructions.
-            if (TID.isCommutable() && mi->getNumOperands() >= 3) {
-              assert(mi->getOperand(3-si).isReg() &&
-                     "Not a proper commutative instruction!");
-              unsigned regC = mi->getOperand(3-si).getReg();
+            unsigned SrcOp1, SrcOp2;
+            if (TID.isCommutable() && mi->getNumOperands() >= 3 &&
+                TII->findCommutedOpIndices(mi, SrcOp1, SrcOp2)) {
+              unsigned regC = 0;
+              if (si == SrcOp1)
+                regC = mi->getOperand(SrcOp2).getReg();
+              else if (si == SrcOp2)
+                regC = mi->getOperand(SrcOp1).getReg();
               if (isKilled(*mi, regC, MRI, TII)) {
                 if (CommuteInstruction(mi, mbbi, regB, regC, Dist)) {
                   ++NumCommuted;

Added: llvm/trunk/test/CodeGen/Thumb/2009-07-20-TwoAddrBug.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb/2009-07-20-TwoAddrBug.ll?rev=76472&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/Thumb/2009-07-20-TwoAddrBug.ll (added)
+++ llvm/trunk/test/CodeGen/Thumb/2009-07-20-TwoAddrBug.ll Mon Jul 20 16:16:08 2009
@@ -0,0 +1,11 @@
+; RUN: llvm-as < %s | llc -mtriple=thumbv6-apple-darwin10
+
+ at Time.2535 = external global i64		; <i64*> [#uses=2]
+
+define arm_apcscc i64 @millisecs() nounwind {
+entry:
+	%0 = load i64* @Time.2535, align 4		; <i64> [#uses=2]
+	%1 = add i64 %0, 1		; <i64> [#uses=1]
+	store i64 %1, i64* @Time.2535, align 4
+	ret i64 %0
+}