[llvm-commits] [llvm] r76385 - in /llvm/trunk: docs/ include/llvm-c/ include/llvm/ include/llvm/Support/ lib/AsmParser/ lib/Bitcode/Reader/ lib/Bitcode/Writer/ lib/CodeGen/ lib/Linker/ lib/Target/ lib/Target/ARM/AsmPrinter/ lib/Target/Alpha/AsmPr

[Chris Lattner]

On Jul 20, 2009, at 11:22 AM, Bill Wendling wrote:

>>>
>>> +++ llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp Sun Jul
>>> 19 20:03:30 2009
>>> @@ -93,12 +93,15 @@
>>>       void Init(const std::string &GV, Mangler *Mang) {
>>>         // Already initialized.
>>>         if (!Stub.empty()) return;
>>> -        Stub = Mang->makeNameProper(GV+"$stub", true);
>>> -        LazyPtr = Mang->makeNameProper(GV+"$lazy_ptr", true);
>>> -        SLP = Mang->makeNameProper(GV+"$slp", true);
>>> -        SCV = Mang->makeNameProper(GV+"$scv", true);
>>> +        Stub = Mang->makeNameProper(GV + "$stub",
>>> +                                    Mangler::PrivatePrefixTy);
>>
>> How about dropping "Ty" from the enum names?
>>
> I'm not good at naming these things, but unfortunately there are
> already variables in the Mangler class named "PrivatePrefix" etc. I'll
> try to think of something better...

How about "Private" then?  That's even better I think.

-Chris