[llvm-commits] [llvm] r76276 - in /llvm/trunk: bindings/ocaml/executionengine/ docs/ docs/tutorial/ examples/BrainF/ examples/Fibonacci/ examples/HowToUseJIT/ examples/Kaleidoscope/ examples/ParallelJIT/ include/llvm/ExecutionEngine/ lib/Executio

[Reid Kleckner]

On Fri, Jul 17, 2009 at 11:11 PM, Daniel Dunbar<daniel at zuster.org> wrote:
> Hi Reid,
>
> Please check my commit r76286.
>
> Also, one comment:
>
> On Fri, Jul 17, 2009 at 5:42 PM, Reid Kleckner<reid at kleckner.net> wrote:
>> +namespace EngineKind {
>> +  // These are actually bitmasks that get or-ed together.
>> +  enum Kind {
>> +    JIT         = 0x1,
>> +    Interpreter = 0x2
>> +  };
>> +  const static Kind Either = (Kind)(JIT | Interpreter);
>> +}
>
> Why put these in a separate namespace? Why not just make a public enum
> inside EngineBuilder? (I haven't been following the JIT API
> discussions, so ignore me if this has already been hashed out)

I was just copying what had been done elsewhere, for example
CodeGenOpt::Type/Default/None/etc.  I can change it back if you like.

Reid