[llvm-commits] [llvm] r75806 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h utils/TableGen/AsmWriterEmitter.cpp

[Sanjiv Gupta]

Sanjiv Gupta wrote:
>> Hmm.  The original code was:
>>
>> 29196    lattner     // For the first operand check, add a default value for 
>> instructions with
>>  29196    lattner     // just opcode strings to use.
>>  29183    lattner     if (isFirst) {
>>  29196    lattner       UniqueOperandCommands.push_back("    return true;\n");
>>  29183    lattner       isFirst = false;
>>  29183    lattner     }
>>
>> The current code is:
>>
>>  29196    lattner     // For the first operand check, add a default value for 
>> instructions with
>>  29196    lattner     // just opcode strings to use.
>>  29183    lattner     if (isFirst) {
>>  75490    greened       // Do the post instruction processing and print the 
>> final newline
>>  75806    greened       UniqueOperandCommands.push_back("    
>> EmitComments(*MI);\n    O << \"\\n\";\n    return true;\n");
>>  29183    lattner       isFirst = false;
>>  29183    lattner     }
>>
>> So the "return true" was always there.  Is it possible this is a bug that's
>> been in AsmWriterEmitter.cpp for a long time?
>>
>>   
>>     
The problem isn't really this piece of code. The way tablegen is 
emitting switch / case statements to print the operands is different.

- Sanjiv