[llvm-commits] [llvm] r76150 - in /llvm/trunk: include/llvm/Instruction.h lib/Analysis/LoopInfo.cpp lib/Transforms/Scalar/LICM.cpp lib/Transforms/Scalar/TailDuplication.cpp lib/Transforms/Utils/SimplifyCFG.cpp lib/VMCore/Instruction.cpp
Duncan Sands
baldrick at free.fr
Fri Jul 17 01:07:00 PDT 2009
Hi Eli,
> + /// undefined behavior. Unlike in mayHaveSideEffects(), allocating memory
> + /// is considered an effect.
this sounds like a bug in mayHaveSideEffects(). Also, it would be good
to have more text explaining the difference between mayHaveSideEffects()
and isSafeToSpeculativelyExecute().
> + /// the operands still dominate it. However, care must be taken with
> + /// instructions which read memory.
I think you should explain why more care is needed here.
Ciao,
Duncan.
More information about the llvm-commits
mailing list