[llvm-commits] [llvm] r76150 - in /llvm/trunk: include/llvm/Instruction.h lib/Analysis/LoopInfo.cpp lib/Transforms/Scalar/LICM.cpp lib/Transforms/Scalar/TailDuplication.cpp lib/Transforms/Utils/SimplifyCFG.cpp lib/VMCore/Instruction.cpp

[Duncan Sands]

Hi Eli,

> +  /// undefined behavior. Unlike in mayHaveSideEffects(), allocating memory
> +  /// is considered an effect.

this sounds like a bug in mayHaveSideEffects().  Also, it would be good
to have more text explaining the difference between mayHaveSideEffects()
and isSafeToSpeculativelyExecute().

> +  /// the operands still dominate it.  However, care must be taken with
> +  /// instructions which read memory.

I think you should explain why more care is needed here.

Ciao,

Duncan.