[llvm-commits] patch: SmallString.append_sinit(INT64_MIN) TODO

[Daniel Dunbar]

The unit test got lost in the shuffle, added it here:
http://llvm.org/viewvc/llvm-project?view=rev&revision=76081

Thanks!
 - Daniel

On Sun, Jul 12, 2009 at 12:41 PM, Ryan Flynn<parseerror at gmail.com> wrote:
> SmallString append_sinit(int64_t) was worried about handling
> INT64_MIN, but it actually did work because -INT_MIN == INT_MIN, and
> the value was then being implicitly converted to uint64_t. i just made
> this conversion explicit.
>
> i also created a unit test demonstrating that SmallString handles this
> case (and append_unit handles UINT64_MAX) properly. the unit test
> should go in unittests/ADT/
>
> Ryan
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>