[llvm-commits] Add line numbers to OProfile

[Chris Lattner]

On Jul 15, 2009, at 4:01 PM, Jeffrey Yasskin wrote:

> On Wed, Jul 15, 2009 at 3:57 PM, Bruno Cardoso
> Lopes<bruno.cardoso at gmail.com> wrote:
>> Hi Jeffrey,
>>
>> On Wed, Jul 15, 2009 at 4:40 PM, Jeffrey  
>> Yasskin<jyasskin at google.com> wrote:
>>> Here's the patch.
>>>
>>> On Wed, Jul 15, 2009 at 12:38 PM, <jyasskin at gmail.com> wrote:
>>>> Reviewers: ,
>>>>
>>>> Message:
>>>> Please take a look. I'll attach the patch shortly. Bruno,  
>>>> especially,
>>>> let me know how I can make this fit better with your long-term  
>>>> plans for
>>>> full Dwarf output.
>>
>> The modifications Regarding the MCE are ok for me, I'd do it in the  
>> same way :)
>> What do you think about using the name processDebugLoc instead of
>> beginDebugLoc?
>
> I used beginDebugLoc because "process" didn't tell me anything about
> what the DebugLoc meant. But I don't mind changing it back and will do
> so unless someone else hollers.
>
> Any other comments, from anyone?

The patch looks reasonable to me.

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090715/9f9b5ba1/attachment.html>