[llvm-commits] [llvm] r75788 - in /llvm/trunk: lib/Target/XCore/XCoreISelLowering.cpp test/CodeGen/XCore/2009-07-15-store192.ll

[Dan Gohman]

On Jul 15, 2009, at 10:01 AM, Richard Osborne wrote:


> Duncan Sands wrote:
>
>> Hi Richard,
>>
>>
>>
>>
>>
>>> Fix XCoreTargetLowering::isLegalAddressingMode to handle non  
>>> simple VTs.
>>>
>>>
>>>
>>
>>
>> are you sure you don't simply want to return "false" if the value  
>> type
>>
>> isn't simple?
>>
>>
>>
>> Ciao,
>>
>>
>>
>> Duncan.
>>
> No, I'm not sure. My reasoning was that, for example, loads / stores  
> of
> i7 will be legalized to loads / stores of i8 and so the addressing  
> modes
> for i7 should be the same as for i8. Is this reasoning faulty?

This reasoning sounds right to me. isLegalAddressingMode is used
from LSR, for example, and since arrays of i7 will be allocated
as arrays of i8, any address that's legal for an array of i8 will
work for an array of i7.

Dan