[llvm-commits] [llvm] r75515 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Chris Lattner
clattner at apple.com
Mon Jul 13 15:25:54 PDT 2009
On Jul 13, 2009, at 3:13 PM, Devang Patel wrote:
>>>
>>> @@ -785,9 +786,11 @@
>>> AddString(GVDie, dwarf::DW_AT_name, dwarf::DW_FORM_string, Name);
>>> std::string LinkageName;
>>> GV.getLinkageName(LinkageName);
>>> - if (!LinkageName.empty())
>>> + if (!LinkageName.empty()) {
>>> + Mangler *Mg = Asm->getMangler();
>>> AddString(GVDie, dwarf::DW_AT_MIPS_linkage_name,
>>> dwarf::DW_FORM_string,
>>> - LinkageName);
>>> + Mg ? Mg->makeNameProper(LinkageName) : LinkageName);
>>
>> Can the mangler ever be null? If not, please remove the two checks.
>
> Just being paranoid.
Please make it an assertion then.
-Chris
More information about the llvm-commits
mailing list