[llvm-commits] [llvm] r75490 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h include/llvm/Target/TargetAsmInfo.h lib/CodeGen/AsmPrinter/AsmPrinter.cpp lib/Target/TargetAsmInfo.cpp utils/TableGen/AsmWriterEmitter.cpp

[Chris Lattner]

On Jul 13, 2009, at 1:40 PM, David Greene wrote:

> On Monday 13 July 2009 15:34, Chris Lattner wrote:
> things.
>>>
>>> This adds interfaces to the AsmPrinter and changes TableGen to  
>>> invoke
>>> the postInstructionAction when appropriate.  It also add  
>>> parameters to
>>> TargetAsmInfo to control comment layout.
>>
>> Ok, are you intending to have specific instructions that have custom
>> hooks?  What hooks?  Why do you need this?
>
> The intent is to allow target asmprinters to override this if  
> necessary.
> Right now the base asmprinter uses it to print comments.
>
> I designed it as a hook because we don't want to keep hacking TableGen
> every time we want to do something new and interesting with asm  
> printing.
> Because hacking TableGen is really voodoo.

Can you remove this piece?  I *strongly* prefer "lazy design" rather  
than "preemptive design", because sometimes when you finally get to  
the place where you need this, you find out that there is a better way  
to go.

-Chris