[llvm-commits] patch: SmallString.append_sinit(INT64_MIN) TODO

Ryan Flynn parseerror at gmail.com
Sun Jul 12 12:41:55 PDT 2009


SmallString append_sinit(int64_t) was worried about handling
INT64_MIN, but it actually did work because -INT_MIN == INT_MIN, and
the value was then being implicitly converted to uint64_t. i just made
this conversion explicit.

i also created a unit test demonstrating that SmallString handles this
case (and append_unit handles UINT64_MAX) properly. the unit test
should go in unittests/ADT/

Ryan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SmallString-append_sint.patch
Type: text/x-diff
Size: 456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090712/d8aa5c5c/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SmallStringTest.cpp
Type: text/x-c++src
Size: 1591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090712/d8aa5c5c/attachment.cpp>


More information about the llvm-commits mailing list