[llvm-commits] [llvm] r75283 - in /llvm/trunk: include/llvm/CodeGen/AsmFormatter.h include/llvm/CodeGen/AsmStream.h include/llvm/Support/FormattedStream.h include/llvm/Support/raw_ostream.h lib/CodeGen/AsmStream.cpp lib/Support/FormattedStream.cpp lib/Support/raw_ostream.cpp

[David Greene]

On Friday 10 July 2009 17:59, David Greene wrote:

> > +  /// AsmComment - An I/O manipulator to output an end-of-line comment
> > +  ///
> > +  class AsmComment : public Column {
> >
> > I still really don't see a reason for this to exist as an I/O
> > manipulator.  This seems like it should be a helper method on
> > AsmPrinter, not an I/O manipulator in a public header.
>
> Let me think about that a bit.

I fiddled around and ended up getting rid of both manipulators.  The resulting 
code's not quite as nice looking but as you say it's in a helper function so 
that hides it a bit.

                                -Dave