[llvm-commits] [llvm] r75102 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp

Chris Lattner sabre at nondot.org
Wed Jul 8 21:43:12 PDT 2009


Author: lattner
Date: Wed Jul  8 23:43:12 2009
New Revision: 75102

URL: http://llvm.org/viewvc/llvm-project?rev=75102&view=rev
Log:
isPICStyleStub() is now never true in -static mode, so simplify code.

Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp?rev=75102&r1=75101&r2=75102&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp Wed Jul  8 23:43:12 2009
@@ -286,10 +286,6 @@
   return ST->isTargetELF() && TM.getRelocationModel() == Reloc::PIC_;
 }
 
-static inline bool shouldPrintStub(TargetMachine &TM, const X86Subtarget* ST) {
-  return ST->isPICStyleStub() && TM.getRelocationModel() != Reloc::Static;
-}
-
 /// print_pcrel_imm - This is used to print an immediate value that ends up
 /// being encoded as a pc-relative value.  These print slightly differently, for
 /// example, a $ is not emitted.
@@ -317,7 +313,7 @@
       needCloseParen = true;
     }
     
-    if (shouldPrintStub(TM, Subtarget)) {
+    if (Subtarget->isPICStyleStub()) {
       // DARWIN/X86-32 in != static mode.
       
       // Link-once, declaration, or Weakly-linked global variables need
@@ -381,10 +377,9 @@
     std::string Name(TAI->getGlobalPrefix());
     Name += MO.getSymbolName();
     // Print function stub suffix unless it's Mac OS X 10.5 and up.
-    if (shouldPrintStub(TM, Subtarget) && 
+    if (Subtarget->isPICStyleStub() && 
         // DARWIN/X86-32 in != static mode.
-        !(Subtarget->isTargetDarwin() && Subtarget->getDarwinVers() >= 9)) {
-      
+        Subtarget->getDarwinVers() < 9) {
       FnStubs.insert(Name);
       printSuffixedName(Name, "$stub");
       return;
@@ -475,7 +470,7 @@
       needCloseParen = true;
     }
 
-    if (shouldPrintStub(TM, Subtarget)) {
+    if (Subtarget->isPICStyleStub()) {
       // DARWIN/X86-32 in != static mode.
 
       // Link-once, declaration, or Weakly-linked global variables need





More information about the llvm-commits mailing list