[llvm-commits] [llvm] r74991 - in /llvm/trunk: docs/ include/llvm-c/ include/llvm/ include/llvm/Bitcode/ include/llvm/Support/ lib/Analysis/ lib/AsmParser/ lib/Bitcode/Reader/ lib/Bitcode/Writer/ lib/CodeGen/SelectionDAG/ lib/Target/ARM/ lib/Transforms/Scalar/ lib/VMCore/ test/Assembler/ test/Transforms/ConstProp/ utils/

[Chris Lattner]

On Jul 7, 2009, at 8:04 PM, Nick Lewycky wrote:

> Author: nicholas
> Date: Tue Jul  7 22:04:38 2009
> New Revision: 74991
>
> URL: http://llvm.org/viewvc/llvm-project?rev=74991&view=rev
> Log:
> Remove the vicmp and vfcmp instructions. Because we never had a  
> release with
> these instructions, no autoupgrade or backwards compatibility  
> support is
> provided.

Nice!

> +++ llvm/trunk/include/llvm/Bitcode/LLVMBitCodes.h Tue Jul  7  
> 22:04:38 2009
> @@ -210,7 +210,8 @@
>     FUNC_CODE_INST_GETRESULT   = 25, // GETRESULT:  [ty, opval, n]
>     FUNC_CODE_INST_EXTRACTVAL  = 26, // EXTRACTVAL: [n x operands]
>     FUNC_CODE_INST_INSERTVAL   = 27, // INSERTVAL:  [n x operands]
> -    // fcmp/icmp returning Int1TY or vector of Int1Ty, NOT for  
> vicmp/vfcmp
> +    // fcmp/icmp returning Int1TY or vector of Int1Ty. Same as CMP,  
> exists to
> +    // support legacy vicmp/vfcmp instructions.
>     FUNC_CODE_INST_CMP2        = 28, // CMP2:       [opty, opval,  
> opval, pred]

Can this just be removed?

-Chris