[llvm-commits] [llvm] r74924 - /llvm/trunk/lib/System/DynamicLibrary.cpp

Chris Lattner sabre at nondot.org
Tue Jul 7 10:50:21 PDT 2009


Author: lattner
Date: Tue Jul  7 12:50:11 2009
New Revision: 74924

URL: http://llvm.org/viewvc/llvm-project?rev=74924&view=rev
Log:
we don't use libtool anymore, update comments.

Modified:
    llvm/trunk/lib/System/DynamicLibrary.cpp

Modified: llvm/trunk/lib/System/DynamicLibrary.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/DynamicLibrary.cpp?rev=74924&r1=74923&r2=74924&view=diff

==============================================================================
--- llvm/trunk/lib/System/DynamicLibrary.cpp (original)
+++ llvm/trunk/lib/System/DynamicLibrary.cpp Tue Jul  7 12:50:11 2009
@@ -23,26 +23,18 @@
 static std::map<std::string, void*> symbols;
 static llvm::sys::SmartRWMutex<true> SymbolsLock;
 
-
 void llvm::sys::DynamicLibrary::AddSymbol(const char* symbolName,
                                           void *symbolValue) {
   llvm::sys::SmartScopedWriter<true> Writer(&SymbolsLock);
   symbols[symbolName] = symbolValue;
 }
 
-// It is not possible to use ltdl.c on VC++ builds as the terms of its LGPL
-// license and special exception would cause all of LLVM to be placed under
-// the LGPL.  This is because the exception applies only when libtool is
-// used, and obviously libtool is not used with Visual Studio.  An entirely
-// separate implementation is provided in win32/DynamicLibrary.cpp.
-
 #ifdef LLVM_ON_WIN32
 
 #include "Win32/DynamicLibrary.inc"
 
 #else
 
-//#include "ltdl.h"
 #include <dlfcn.h>
 #include <cassert>
 using namespace llvm;
@@ -53,7 +45,6 @@
 //===          independent code.
 //===----------------------------------------------------------------------===//
 
-//static std::vector<lt_dlhandle> OpenedHandles;
 static std::vector<void *> OpenedHandles;
 
 DynamicLibrary::DynamicLibrary() {}
@@ -61,7 +52,8 @@
 DynamicLibrary::~DynamicLibrary() {
   SmartScopedWriter<true> Writer(&SymbolsLock);
   while(!OpenedHandles.empty()) {
-    void *H = OpenedHandles.back();   OpenedHandles.pop_back(); 
+    void *H = OpenedHandles.back();
+    OpenedHandles.pop_back(); 
     dlclose(H);
   }
 }
@@ -80,8 +72,6 @@
 }
 
 void* DynamicLibrary::SearchForAddressOfSymbol(const char* symbolName) {
-  //  check_ltdl_initialization();
-  
   // First check symbols added via AddSymbol().
   SymbolsLock.reader_acquire();
   std::map<std::string, void *>::iterator I = symbols.find(symbolName);





More information about the llvm-commits mailing list