[llvm-commits] [patch] Minor X86CodeEmitter Memory Foot Reduction

[Chris Lattner]

On Jul 6, 2009, at 1:17 PM, Aaron Gray wrote:

>>>
>>> X86CodeEmitter.cpp be shared across all 3?
>>
>> I agree with Evan, I don't see why this code shouldn't be shared,
>> besides that, putting
>> all that code in a header file doesn't seems like the right approach.
>
> Its the right approach.
>
> It allows us to have separate object modules thus reducing memory  
> overheads
> for other projects that at least one other person has been asking for.
>
> Putting templated code in headers and instatiating separately  
> in .cpp files
> is quite common practice once you use templating alot.

Hi Guys,

I'm behind on code review, but why is this stuff templated at all?   
This seems very wrong.  We *really* care about the JIT code size  
footprint and templating the whole emitter is not a good way to help  
footprint :)

-Chris