[llvm-commits] PATCH: remove VICmp and VFCmp.

[Chris Lattner]

On Jul 5, 2009, at 10:16 PM, Nick Lewycky wrote:

> This patch removes vicmp and vfcmp, which has the positive side that  
> it fixes existing type-safety bugs and simplifies some code, but a  
> downside in that it XFAILs 9 CodeGen tests.

I haven't had a chance to look at the patch, but removing v[fi]cmp  
will almost certainly break clang (which generates them for vector  
comparisons in opencl/ext_vector mode).  The right way to remove this  
is to make codegen pattern match [fi]cmp+sext to the same nodes it is  
using for v[fi]cmp, then change clang to generate [fi]cmp+sext instead  
of v[if]cmp, then nuke v[fi]cmp.  This way we won't loose any codegen  
capability and clang will still build :).

I'm happy to help with this, but I won't have time to for another  
couple days.

-Chris