[llvm-commits] [PATCH] Fix for llvm::FindExecutable (fails to find executable if path is provided)

Daniel Dunbar daniel at zuster.org
Wed Jul 1 14:36:50 PDT 2009


I applied this this morning but forgot to send an email about it, I
applied it here:
http://llvm.org/viewvc/llvm-project?view=rev&revision=74608

Your comment below makes sense, however, so I tweaked it again here:
http://llvm.org/viewvc/llvm-project?view=rev&revision=74645
so that relative paths work. Does this look reasonable to you? Also,
does it work? :)

 - Daniel

On Wed, Jul 1, 2009 at 10:04 AM, Viktor
Kutuzov<vkutuzov at accesssoftek.com> wrote:
> Hi Chris,
>
>> Please use sys::Path::isAbsolute to check to see if it is an absolute
>
> I didn't want to check if it is an absolute, I wanted to check if there is any directory part (absolute or relative).
> Is there anything wrong with relative path?
> It seems the right way to do this would be adding Path::hasDirname() method and use it there instead.
>
> What do you think?
>
> Best regards,
> Viktor
>
> ----- Original Message -----
> From: "Chris Lattner" <clattner at apple.com>
> To: "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>
> Cc: "Viktor Kutuzov" <vkutuzov at accesssoftek.com>
> Sent: Wednesday, July 01, 2009 8:44 AM
> Subject: Re: [llvm-commits] [PATCH] Fix for llvm::FindExecutable (fails to find executable if path is provided)
>
>
>>
>> On Jun 30, 2009, at 11:52 PM, Viktor Kutuzov wrote:
>>
>>> Hello everyone,
>>>
>>> The llvm::FindExecutable fails to find a named executible if full
>>> path is provided.
>>
>> Hi Viktor,
>>
>> Please use sys::Path::isAbsolute to check to see if it is an absolute
>> path, this will work on windows as well as unix.  Thanks,
>>
>> -Chris
>>
>>>
>>> Please find the patch attached.
>>>
>>> Best regards,
>>> Viktor
>>> <SystemUtils.cpp.diff>_______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list