[llvm-commits] [llvm-gcc-4.2] r74575 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Chris Lattner]

On Jul 1, 2009, at 10:29 AM, Dale Johannesen wrote:

>>>
>>> Ok, works for me.  Please don't use it in normal llvm code though,
>>> llvm-gcc is fine.
>>
>> it was used in two places in the llvm parts of llvm-gcc before.   
>> Since
>> the llvm style is to use SmallVector, can you please modify all  
>> places
>> to use SmallVector instead of alloca.
>
> No, this code is part of gcc, so gcc style should be OK; the llvm*
> files are a mix of the styles as it is.  Besides, I consider worrying
> about this a complete waste of time (as a corollary, however, I never
> object to other people's stylistic changes).

Duncan is the code owner of llvm-gcc, so if he strongly prefers it one  
way or the other, it's his call :-).  Duncan?

-Chris