[llvm-commits] [llvm] r74478 - in /llvm/trunk: include/llvm/MC/MCStreamer.h lib/MC/MCAsmStreamer.cpp test/MC/AsmParser/directive_align.s tools/llvm-mc/AsmParser.cpp tools/llvm-mc/AsmParser.h

[Chris Lattner]

On Jun 29, 2009, at 4:47 PM, Daniel Dunbar wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=74478&view=rev
> Log:
> llvm-mc: Parse .{,b,p2}align{,w,l} directives.

> +++ llvm/trunk/include/llvm/MC/MCStreamer.h Mon Jun 29 18:46:59 2009
> @@ -135,7 +135,7 @@
>     /// This used to implement the .align assembler directive.
>     ///
>     /// @param ByteAlignment - The alignment to reach. This must be  
> a power of
> -    /// two.
> +    /// two on some targets.

What is the right answer here for .align?  Though slightly incovenient  
for the asm/printer, I think it makes sense to make the interface to  
be target-independent.  For example, the alignment could always be  
specified in log2 form.  If the TargetAsmInfo says that .align is not  
in log2 form, the parser/printer would be responsible for changing  
it.  This approach is convenient for the code generator.  What do you  
think?

-Chris