[llvm-commits] [llvm] r74288 - in /llvm/trunk: lib/Target/ARM/ARMInstrThumb2.td test/CodeGen/Thumb2/thumb2-mov3.ll test/CodeGen/Thumb2/thumb2-mov4.ll

[Bill Wendling]

Hi David,

These are failing on one of the Google buildbots:

http://google1.osuosl.org:8011/builders/llvm-i686-linux/builds/3278

Could you look into this please?

-bw

On Fri, Jun 26, 2009 at 9:10 AM, David Goodwin<david_goodwin at apple.com> wrote:
> Author: david_goodwin
> Date: Fri Jun 26 11:10:07 2009
> New Revision: 74288
>
> URL: http://llvm.org/viewvc/llvm-project?rev=74288&view=rev
> Log:
> Currently there is a pattern for the thumb-2 MOV 16-bit immediate instruction. That instruction cannot write the flags so it should use T2I instead of T2sI.
> Also, added a pattern for the thumb-2 MOV of shifted immediate since that can encode immediates not encodable by the 16-bit immediate.
>
> Added:
>    llvm/trunk/test/CodeGen/Thumb2/thumb2-mov3.ll
>    llvm/trunk/test/CodeGen/Thumb2/thumb2-mov4.ll
> Modified:
>    llvm/trunk/lib/Target/ARM/ARMInstrThumb2.td
>
> Modified: llvm/trunk/lib/Target/ARM/ARMInstrThumb2.td
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMInstrThumb2.td?rev=74288&r1=74287&r2=74288&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMInstrThumb2.td (original)
> +++ llvm/trunk/lib/Target/ARM/ARMInstrThumb2.td Fri Jun 26 11:10:07 2009
> @@ -409,9 +409,14 @@
>                    "mov", " $dst, $src", []>;
>
>  let isReMaterializable = 1, isAsCheapAsAMove = 1 in
> -def t2MOVi16 : T2sI<(outs GPR:$dst), (ins i32imm:$src),
> -                    "movw", " $dst, $src",
> -                    [(set GPR:$dst, imm0_65535:$src)]>;
> +def t2MOVi : T2sI<(outs GPR:$dst), (ins t2_so_imm:$src),
> +                   "mov", " $dst, $src",
> +                   [(set GPR:$dst, t2_so_imm:$src)]>;
> +
> +let isReMaterializable = 1, isAsCheapAsAMove = 1 in
> +def t2MOVi16 : T2I<(outs GPR:$dst), (ins i32imm:$src),
> +                   "movw", " $dst, $src",
> +                   [(set GPR:$dst, imm0_65535:$src)]>;
>
>  // FIXME: Also available in ARM mode.
>  let Constraints = "$src = $dst" in
>
> Added: llvm/trunk/test/CodeGen/Thumb2/thumb2-mov3.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/thumb2-mov3.ll?rev=74288&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/Thumb2/thumb2-mov3.ll (added)
> +++ llvm/trunk/test/CodeGen/Thumb2/thumb2-mov3.ll Fri Jun 26 11:10:07 2009
> @@ -0,0 +1,33 @@
> +; RUN: llvm-as < %s | llc | grep {mov\\W*r\[0-9\],\\W*#\[0-9\]*} | grep {#171\\|#1179666\\|#872428544\\|#1448498774\\|#66846720} | Count 5
> +
> +target triple = "thumbv7-apple-darwin"
> +
> +; 171 = 0x000000ab
> +define i32 @f1(i32 %a) {
> +    %tmp = add i32 0, 171
> +    ret i32 %tmp
> +}
> +
> +; 1179666 = 0x00120012
> +define i32 @f2(i32 %a) {
> +    %tmp = add i32 0, 1179666
> +    ret i32 %tmp
> +}
> +
> +; 872428544 = 0x34003400
> +define i32 @f3(i32 %a) {
> +    %tmp = add i32 0, 872428544
> +    ret i32 %tmp
> +}
> +
> +; 1448498774 = 0x56565656
> +define i32 @f4(i32 %a) {
> +    %tmp = add i32 0, 1448498774
> +    ret i32 %tmp
> +}
> +
> +; 66846720 = 0x03fc0000
> +define i32 @f5(i32 %a) {
> +    %tmp = add i32 0, 66846720
> +    ret i32 %tmp
> +}
>
> Added: llvm/trunk/test/CodeGen/Thumb2/thumb2-mov4.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/thumb2-mov4.ll?rev=74288&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/Thumb2/thumb2-mov4.ll (added)
> +++ llvm/trunk/test/CodeGen/Thumb2/thumb2-mov4.ll Fri Jun 26 11:10:07 2009
> @@ -0,0 +1,8 @@
> +; RUN: llvm-as < %s | llc | grep {movw\\W*r\[0-9\],\\W*#\[0-9\]*} | grep {#65535} | Count 1
> +
> +target triple = "thumbv7-apple-darwin"
> +
> +define i32 @f6(i32 %a) {
> +    %tmp = add i32 0, 65535
> +    ret i32 %tmp
> +}
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>