[llvm-commits] [llvm] r74251 - in /llvm/trunk: docs/SourceLevelDebugging.html include/llvm/Analysis/DebugInfo.h lib/Analysis/DebugInfo.cpp lib/CodeGen/AsmPrinter/DwarfDebug.cpp lib/CodeGen/AsmPrinter/DwarfDebug.h lib/Transforms/IPO/StripSymbols.cpp

[Devang Patel]

On Jun 25, 2009, at 7:10 PM, Chris Lattner wrote:

>
> On Jun 25, 2009, at 6:49 PM, Devang Patel wrote:
>
>> Author: dpatel
>> Date: Thu Jun 25 20:49:18 2009
>> New Revision: 74251
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=74251&view=rev
>> Log:
>>
>> Remove debug info anchors - llvm.dbg.compile_units,
>> llvm.dbg.subprograms
>> and llvm.dbg.global_variables.
>
> Great, thank you for doing this Devang:
>
>> +++ llvm/trunk/include/llvm/Analysis/DebugInfo.h Thu Jun 25 20:49:18
>> 2009
>> @@ -17,9 +17,12 @@
>> +#include "llvm/Module.h"
>> +#include "llvm/GlobalVariable.h"
>
> Please just forward declare classes instead of #including their
> headers.  There should be no reason to bring these in to the .h file.

ok

>
>
>> +  /// CollectDebugInfoAnchors - Collect debugging information
>> anchors.
>> +  void CollectDebugInfoAnchors(Module &M,
>> +                               SmallVector<GlobalVariable *, 2>  
>> &CUs,
>> +                               SmallVector<GlobalVariable *, 4>  
>> &GVs,
>> +                               SmallVector<GlobalVariable *, 4>
>> &SPs) {
>
> Is this just temporary?

Yes.

-
Devang