[llvm-commits] [llvm] r74240 - /llvm/trunk/lib/Transforms/Scalar/LoopRotation.cpp

[Chris Lattner]

On Jun 25, 2009, at 5:26 PM, Dan Gohman wrote:

> Author: djg
> Date: Thu Jun 25 19:26:03 2009
> New Revision: 74240
>
> URL: http://llvm.org/viewvc/llvm-project?rev=74240&view=rev
> Log:
> Minor code simplification.

Hey Dan,

This construct makes VC++ unhappy:


> +  for (BasicBlock::iterator I = Exit->begin();
> +       PHINode *PN = dyn_cast<PHINode>(I); ++I) {

Please write it something like this:


      PHINode *PN;
> +  for (BasicBlock::iterator I = Exit->begin();
> +       (PN = dyn_cast<PHINode>(I)); ++I) {


Thanks,

-Chris