[llvm-commits] [patch] test suite documentation updates, new "XFAIL: disable_assertions"

[Bill Wendling]

On Thu, Jun 25, 2009 at 11:19 AM, Shantonu Sen<ssen at apple.com> wrote:
> I was getting a test suite failure with a Release-Asserts build on
> test/CodeGen/PowerPC/int-fp-conv-0.ll because it does:
>
>>  ; RUN: llvm-as < %s | llc -march=ppc64 -debug |& not grep {= store}
>
> "llc -debug" is only available when assertions are enabled, so there should
> be a way to XFAIL this when assertions are disabled. I added this ability to
> the llvm dejagnu tests, and now the test PASSes for a Debug build, and
> XFAILs for Release-Asserts.
>
Relying upon grepping the output of the '-debug' flag is a Bad
Thing(tm). Someone should just make this test work the standard way
(grepping .ll files) or remove it.

-bw

> I noticed a bunch of other documentation issues that I ran into, which I
> expanded on.
>
> Chris L. says that --with-f2c hasn't been supported in a while, and should
> probably be removed, so I did (it also breaks W3C validation of the HTML)
>
> Mac OS X has shipped Tcl and expect since 10.4 at least, I don't think it's
> relevant to recommend ways to install them.
>
> Diff attached
>
>
>
> Shantonu Sen
> ssen at apple.com
>
> Sent from my Mac Pro
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>