[llvm-commits] [llvm] r74130 - in /llvm/trunk/include/llvm: CodeGen/ValueTypes.h Target/TargetLowering.h

Duncan Sands baldrick at free.fr
Thu Jun 25 01:25:01 PDT 2009


Hi David,

>        // This is the current maximum for LAST_VALUETYPE.
>        // Affects ValueTypeActions in TargetLowering.h.

I don't think this "Affects ValueTypeActions..." comment should be here.
Better to have places that use MAX_ALLOWED_VALUETYPE use it in a clear
way that can be found by searching.  In fact if you search you will find
ValueTypeActions already...  Also, the comment is already out of date
(OpActions is also affected).

Ciao,

Duncan.



More information about the llvm-commits mailing list