[llvm-commits] [llvm] r74164 - /llvm/trunk/lib/Target/ARM/ARMSubtarget.h

[Evan Cheng]

I am not sure about this. Some ARM instructions are only available  
when Thumb2 is available. But using hasThumb2() predicate in ARM mode  
just seem strange.

How about leaving the predicate in but change it to "return  
ARMArchVersion >= V6 && ThumbMode >= Thumb2"?

Evan

On Jun 24, 2009, at 10:20 PM, Bob Wilson wrote:

> Author: bwilson
> Date: Thu Jun 25 00:20:31 2009
> New Revision: 74164
>
> URL: http://llvm.org/viewvc/llvm-project?rev=74164&view=rev
> Log:
> Remove unused hasV6T2Ops method.  We already have a separate feature  
> to
> identify Thumb2.
>
> Modified:
>    llvm/trunk/lib/Target/ARM/ARMSubtarget.h
>
> Modified: llvm/trunk/lib/Target/ARM/ARMSubtarget.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMSubtarget.h?rev=74164&r1=74163&r2=74164&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/ARM/ARMSubtarget.h (original)
> +++ llvm/trunk/lib/Target/ARM/ARMSubtarget.h Thu Jun 25 00:20:31 2009
> @@ -93,7 +93,6 @@
>   bool hasV5TOps()  const { return ARMArchVersion >= V5T;  }
>   bool hasV5TEOps() const { return ARMArchVersion >= V5TE; }
>   bool hasV6Ops()   const { return ARMArchVersion >= V6;   }
> -  bool hasV6T2Ops() const { return ARMArchVersion >= V6T2; }
>   bool hasV7Ops()   const { return ARMArchVersion >= V7A;  }
>
>   bool hasVFP2() const { return ARMFPUType >= VFPv2; }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits