[llvm-commits] [llvm] r73778 - /llvm/trunk/lib/VMCore/Constants.cpp

[Owen Anderson]

Author: resistor
Date: Fri Jun 19 13:34:09 2009
New Revision: 73778

URL: http://llvm.org/viewvc/llvm-project?rev=73778&view=rev
Log:
Forgot to remove some explicit locking when it became implicit in the ValueMap.

Modified:
    llvm/trunk/lib/VMCore/Constants.cpp

Modified: llvm/trunk/lib/VMCore/Constants.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Constants.cpp?rev=73778&r1=73777&r2=73778&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Constants.cpp (original)
+++ llvm/trunk/lib/VMCore/Constants.cpp Fri Jun 19 13:34:09 2009
@@ -1473,6 +1473,7 @@
 /// destroyConstant - Remove the constant from the constant table...
 ///
 void ConstantArray::destroyConstant() {
+  // Implicitly locked.
   ArrayConstants->remove(this);
   destroyConstantImpl();
 }
@@ -1601,6 +1602,7 @@
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantStruct::destroyConstant() {
+  // Implicitly locked.
   StructConstants->remove(this);
   destroyConstantImpl();
 }
@@ -1668,7 +1670,7 @@
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantVector::destroyConstant() {
-  sys::SmartScopedWriter<true> Write(&*ConstantsLock);
+  // Implicitly locked.
   VectorConstants->remove(this);
   destroyConstantImpl();
 }
@@ -1740,7 +1742,7 @@
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantPointerNull::destroyConstant() {
-  sys::SmartScopedWriter<true> Writer(&*ConstantsLock);
+  // Implicitly locked.
   NullPtrConstants->remove(this);
   destroyConstantImpl();
 }
@@ -2721,7 +2723,7 @@
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantExpr::destroyConstant() {
-  sys::SmartScopedWriter<true> Writer(&*ConstantsLock);
+  // Implicitly locked.
   ExprConstants->remove(this);
   destroyConstantImpl();
 }