[llvm-commits] [llvm] r73401 - /llvm/trunk/lib/Analysis/IVUsers.cpp

[Sanjiv Gupta]

>>>
>>>
>>> +  AddRecStart = SE->getSCEVAtScope(AddRecStart, UseLoop);
>>>
>>> +  SCEVHandle AddRecStride = AddRec->getStepRecurrence(*SE);
>>>
>>> +  AddRecStride = SE->getSCEVAtScope(AddRecStride, UseLoop);
>>>
>>>
>>>
>> Dan,
>>
>> Since you meant only code cleanup, the last line I think is left 
>> there by mistake as in the original code we had only one call to
>>
>> SE->getSCEVAtScope(AddRecStart, UseLoop); which is already there two 
>> lines above.
>
> Hmm, you're right that this wasn't pure cleanup. This commit is a
> change I had split out from a larger patch, and I missed that detail.
> The call isn't redundant though; the first call is doing getSCEVAtScope
> for the Start expression, and the second is doing it for the Stride
> expression. This probably isn't especially valuable at the moment,
> but it shouldn't cause trouble.
>
> Dan
>
It is causing trouble. Few of our test cases broke. They run fine if I 
remove the last call though.

- Sanjiv