[llvm-commits] [PATCH] Remove GNU particuliers from NewNightlyTest.pl , more system portable.

Bob Wilson bob.wilson at apple.com
Thu Jun 18 11:43:26 PDT 2009


Nice cleanup.  Thanks, Benjamin.  I'm going to try it out with my  
nightly tester.  If everything goes well, I'll commit your patch  
tomorrow.

On Jun 18, 2009, at 4:31 AM, Benjamin Kramer wrote:

> Sorry, but seeing this ugly perl code almost made my cry (not your  
> fault though). So I decided to port it to File::Find which is part  
> of perl's standard library.
>
> This gives us some advantages:
> 1. portability: File::Find works even on windows ;)
> 2. performance: the new code is >100 times faster on my machine. The  
> slowdown is probably caused by backtracking in the old regex
> 3. cleanup: there were lots of duplicated code
>
>
> <nightlyfind.patch>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list